Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 )
Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 ...................................................................... Patch Set 23: (4 comments) http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java: http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@1 PS23, Line 1: /// Licensed to the Apache Software Foundation (ASF) under one Extra / ? http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@403 PS20, Line 403: } > C++ API specifically doesn't allow implicit casting at this point so GetVar Yeah, I think that is okay as long as we are consistent. Users can always use getObject if they don't want to handle each getter explicitly. http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@151 PS20, Line 151: > fair enough, removing it. Does this mean it's not possible to create a VARC You can still use the Kudu Schema based table creation to create a VARCHAR column as opposed to the Spark StructType. http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala: http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@139 PS23, Line 139: // Add ColumnTypeAttributesBuilder to DECIMAL and VARCHAR columns Remove "and VARCHAR" -- To view, visit http://gerrit.cloudera.org:8080/14050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995 Gerrit-Change-Number: 14050 Gerrit-PatchSet: 23 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 04 Oct 2019 15:52:37 +0000 Gerrit-HasComments: Yes
