Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2 ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/13869/21/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/13869/21/src/kudu/client/schema.h@99 PS21, Line 99: KuduColumnTypeAttributes(int8_t precision, int8_t scale, uint16_t length); Why do we want this constructor? Isn't it an error to specify precision, scale, and length? http://gerrit.cloudera.org:8080/#/c/13869/21/src/kudu/integration-tests/varchar-itest.cc File src/kudu/integration-tests/varchar-itest.cc: http://gerrit.cloudera.org:8080/#/c/13869/21/src/kudu/integration-tests/varchar-itest.cc@68 PS21, Line 68: char/varchar Just "varchar" now. -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 21 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:38 +0000 Gerrit-HasComments: Yes
