Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14345
to look at the new patch set (#2).
Change subject: [mini_cluster] small fix on Mini{Chronyd,Hms}::Start()
......................................................................
[mini_cluster] small fix on Mini{Chronyd,Hms}::Start()
This patch makes it possible to start ExternalMiniCluster on a directory
structure created by its prior instance if using the masters' RPC
end-points from the very first run.
This functionality is useful for test scenarios like
MasterMigrationTest.TestEndToEndMigration, when a Kudu master catalog
is preserved between cluster's restarts.
The motivation for this patch was seeing the mentioned test scenario
failed if running with the built-in NTP: mini_chronyd wasn't recreating
the configuration file for chronyd (the test NTP server) as necessary
in MiniChronyd::Start(). I also found that running the scenario with
HMS enabled would fail as well, so I updated MiniHms::Start()
accordingly.
In addition, I updated the ExternalMiniClusterTest.TestBasicOperation
test scenario to cover the updated functionality.
Change-Id: I014eac84386c4d6e4f025afc1082e6a229a97454
---
M src/kudu/clock/test/mini_chronyd.cc
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
M src/kudu/mini-cluster/external_mini_cluster-test.cc
4 files changed, 130 insertions(+), 102 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/14345/2
--
To view, visit http://gerrit.cloudera.org:8080/14345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I014eac84386c4d6e4f025afc1082e6a229a97454
Gerrit-Change-Number: 14345
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
