Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/14345 )
Change subject: [mini_cluster] small fix on Mini{Chronyd,Hms}::Start()
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14345/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14345/3//COMMIT_MSG@18
PS3, Line 18: mini_chronyd wasn't recreating
: the configuration file for chronyd (the test NTP server) as
necessary
: in MiniChronyd::Start().
> Since we use ephemeral port reservation technique for chronyd, next run of
FWIW, this explanation is a bit confusing because, based on our earlier
discussion, chronyd itself doesn't support ephemeral port binding. But I get
what you're saying: ExternalMiniCluster does the ephemeral port binding, then
hands off the port to chronyd.
http://gerrit.cloudera.org:8080/#/c/14345/3/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:
http://gerrit.cloudera.org:8080/#/c/14345/3/src/kudu/hms/mini_hms.cc@161
PS3, Line 161: // Run the schematool to initialize the database if not yet
initialized.
> Yep, it slows it down 1/3 (at 2GHz 16 code machine with a lot of memory and
Maybe we can figure this out another way? Looks like the Derby database gets
written to <data_root_>/warehouse. Could we check if that directory exists, and
if so, skip the call to schematool?
--
To view, visit http://gerrit.cloudera.org:8080/14345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I014eac84386c4d6e4f025afc1082e6a229a97454
Gerrit-Change-Number: 14345
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 03 Oct 2019 00:08:34 +0000
Gerrit-HasComments: Yes
