Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/14345 )
Change subject: [mini_cluster] small fix on Mini{Chronyd,Hms}::Start()
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/14345/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14345/3//COMMIT_MSG@9
PS3, Line 9: This patch makes it possible to start ExternalMiniCluster on a
directory
: structure created by its prior instance if using the masters' RPC
: end-points from the very first run.
> Maybe clearer as: "This patch makes it possible to start ExternalMiniCluste
Thanks!
Done.
http://gerrit.cloudera.org:8080/#/c/14345/3//COMMIT_MSG@18
PS3, Line 18: mini_chronyd wasn't recreating
: the configuration file for chronyd (the test NTP server) as
necessary
: in MiniChronyd::Start().
> FWIW, this explanation is a bit confusing because, based on our earlier dis
I updated the explanation. Hopefully it's clearer now.
http://gerrit.cloudera.org:8080/#/c/14345/3/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:
http://gerrit.cloudera.org:8080/#/c/14345/3/src/kudu/hms/mini_hms.cc@161
PS3, Line 161: // Run the schematool to initialize the database if not yet
initialized.
> Maybe we can figure this out another way? Looks like the Derby database get
This sounds like a good idea, thanks. Done.
http://gerrit.cloudera.org:8080/#/c/14345/3/src/kudu/mini-cluster/external_mini_cluster-test.cc
File src/kudu/mini-cluster/external_mini_cluster-test.cc:
http://gerrit.cloudera.org:8080/#/c/14345/3/src/kudu/mini-cluster/external_mini_cluster-test.cc@290
PS3, Line 290: // Shutdown the cluster explicitly.
: cluster->Shutdown();
> Maybe, we still need to test an explicit call of MiniClusterShutdown()? I'
OK, I added a comment that the call of it is redundant if thinking about
shutting down cluster's compoments, but it's done just in the context of
testing.
--
To view, visit http://gerrit.cloudera.org:8080/14345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I014eac84386c4d6e4f025afc1082e6a229a97454
Gerrit-Change-Number: 14345
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 03 Oct 2019 17:07:42 +0000
Gerrit-HasComments: Yes
