Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 )
Change subject: KUDU-2800 Test long bootstrapping tablet replicas ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/14300/10/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: http://gerrit.cloudera.org:8080/#/c/14300/10/src/kudu/integration-tests/raft_config_change-itest.cc@635 PS10, Line 635: > This duration is equal to "tablet_open_bootstrap_inject_latency_ms". The i Makes sense, thanks for the explanation! http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc@484 PS13, Line 484: ever server http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc@518 PS13, Line 518: false, nit: While this helps emphasize that we're not falling behind in this test, we're not writing either. This means that we should be able to tolerate frequent log rolling and still not move the replica, right? If so, we could probably get rid of this boolean entirely and roll logs frequently, since there's no risk of falling behind. http://gerrit.cloudera.org:8080/#/c/14300/13/src/kudu/integration-tests/raft_config_change-itest.cc@571 PS13, Line 571: auto replica_ets = cluster_->tablet_server_by_uuid(any_replica_server); nit: Isn't this just `ts`? -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 13 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 09 Oct 2019 05:11:51 +0000 Gerrit-HasComments: Yes
