Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 )
Change subject: KUDU-2800 Test long bootstrapping tablet replicas ...................................................................... Patch Set 15: (16 comments) http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@10 PS14, Line 10: a tablet repli > nit: a tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@11 PS14, Line 11: The follow > nit: The following cases Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@13 PS14, Line 13: A tablet repli > A tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: he replica is not evicted from > It might be a bit of overstatement: leader replica might change during that Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: that time. > nit: during this time Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@16 PS14, Line 16: ished. > A tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@17 PS14, Line 17: > the replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: ca is s > The replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: ome > finds Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: During this time > that is has been evicted from the tablet Raft configuration Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@20 PS14, Line 20: replication). > A tablet replica Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: > The replica eventually starts Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: > that it has been evicted from the tablet Raft configuration Done http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: > finds Done http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@141 PS11, Line 141: tablet_bootstrap_inject_latency_ms, 0, > It seems you didn't address (missed?) this comment. Sorry, missed that comment. http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@142 PS11, Line 142: "Injects latency into the tablet bootstrapping." > It seems you didn't address (missed?) this comment. Sorry, missed that comment. Where to add a space ? -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 15 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 11 Oct 2019 22:19:46 +0000 Gerrit-HasComments: Yes
