Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14300 )
Change subject: KUDU-2800 Test long bootstrapping tablet replicas ...................................................................... Patch Set 14: (16 comments) http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@10 PS14, Line 10: tablet replica nit: a tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@11 PS14, Line 11: There case nit: The following cases http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@13 PS14, Line 13: Tablet replica A tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: these time nit: during this time http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@14 PS14, Line 14: Consensus state does not change It might be a bit of overstatement: leader replica might change during that period, etc. To be specific, maybe rephrase with: The replica is not evicted from the tablet Raft configuration and joins the quorum after the bootstrapping process is finished. http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@16 PS14, Line 16: Tablet replica A tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@17 PS14, Line 17: replica the replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: Replica The replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: the it fell behind that is has been evicted from the tablet Raft configuration http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@18 PS14, Line 18: find finds http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@20 PS14, Line 20: Tablet replica A tablet replica http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: the it fell behind that it has been evicted from the tablet Raft configuration http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: find finds http://gerrit.cloudera.org:8080/#/c/14300/14//COMMIT_MSG@22 PS14, Line 22: Replica restarts The replica eventually starts http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@141 PS11, Line 141: tablet_open_bootstrap_inject_latency_ms > nit: why not simply tablet_bootstrap_inject_latency_ms ? It seems you didn't address (missed?) this comment. http://gerrit.cloudera.org:8080/#/c/14300/11/src/kudu/tserver/ts_tablet_manager.cc@142 PS11, Line 142: "Injects latency into the tablet bootstrapping." > nit: add a space It seems you didn't address (missed?) this comment. -- To view, visit http://gerrit.cloudera.org:8080/14300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fee42053194f51d7a869ce14788095d6627ed9 Gerrit-Change-Number: 14300 Gerrit-PatchSet: 14 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 11 Oct 2019 21:47:27 +0000 Gerrit-HasComments: Yes
