Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablets count and on_disk size on /tables ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: PS1: For consistency, let's avoid JSON variables with spaces in them. Use underscores instead. http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc@266 PS1, Line 266: vector<scoped_refptr<TabletInfo>> tablets; : table->GetAllTablets(&tablets); : table_json["tablets count"] = Substitute("$0", tablets.size()); Could call table->num_tablets() instead. http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache File www/tables.mustache: http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache@38 PS1, Line 38: leaders only Do you think "pre-replication" is clearer? -- To view, visit http://gerrit.cloudera.org:8080/14694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e Gerrit-Change-Number: 14694 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Nov 2019 08:54:16 +0000 Gerrit-HasComments: Yes
