Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablets count and on_disk size on /tables ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: PS1: > For consistency, let's avoid JSON variables with spaces in them. Use unders Done http://gerrit.cloudera.org:8080/#/c/14694/1/src/kudu/master/master_path_handlers.cc@266 PS1, Line 266: table_json["tablets_count"] = Substitute("$0", table->num_tablets()); : const TableMetrics* table_metrics = table->GetMetrics(); : if (table_metrics) { > Could call table->num_tablets() instead. Done http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache File www/tables.mustache: http://gerrit.cloudera.org:8080/#/c/14694/1/www/tables.mustache@38 PS1, Line 38: pre-replicat > Do you think "pre-replication" is clearer? Done -- To view, visit http://gerrit.cloudera.org:8080/14694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e Gerrit-Change-Number: 14694 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2019 09:54:14 +0000 Gerrit-HasComments: Yes
