Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14694 )
Change subject: www: add tablet_count and on_disk_size on /tables ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14694/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14694/2//COMMIT_MSG@9 PS2, Line 9: Add tablet_count and on_disk_size > Nit: "Add tablet_count and on_disk_size" Done http://gerrit.cloudera.org:8080/#/c/14694/2/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/14694/2/src/kudu/master/master_path_handlers.cc@266 PS2, Line 266: table_json["tablet_count"] = HumanReadableInt::ToString(table->num_tablets()); > Maybe HumanReadableInt here? Done http://gerrit.cloudera.org:8080/#/c/14694/2/www/tables.mustache File www/tables.mustache: http://gerrit.cloudera.org:8080/#/c/14694/2/www/tables.mustache@37 PS2, Line 37: Tablet Count< > Nit: Tablet Count Done -- To view, visit http://gerrit.cloudera.org:8080/14694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4937826eda0d095a36208fa34fa9c992570e71e Gerrit-Change-Number: 14694 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2019 10:46:54 +0000 Gerrit-HasComments: Yes
