Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )
Change subject: [java] Fix kudu-client checkstyle warnings ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@447 PS2, Line 447: getFakeMasterUuid(hostPort), A bit of bike-shedding: if checkstyle so picky, then, maybe, more consistent approach to list arguments would be return newRpcProxy( new ServerInfo( getFakeMasterUuid(hostPort), hostPort, ...), credentialsPolicy); ? -- To view, visit http://gerrit.cloudera.org:8080/14775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9 Gerrit-Change-Number: 14775 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Nov 2019 23:24:46 +0000 Gerrit-HasComments: Yes
