Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )
Change subject: [java] Fix kudu-client checkstyle warnings ...................................................................... Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java File java/kudu-client/src/main/java/org/apache/kudu/Type.java: http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java@59 PS3, Line 59: Private nit: it's no longer private. Or it means package private? Also, is it necessary to add an empty line between the short description and the list of parameters? http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java File java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java: http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java@97 PS3, Line 97: "<start>" : Bytes.hex(primaryKeyStart), Is this what checkstyle recommends? For some reason, I found it a bit harder to read than the original variant. I don't have a strong opinion on this, but I'm just curious on the style preferred by the checkstyle plugin. http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@453 PS3, Line 453: saslCallback); nit: any reason to have this is so out-of-bound compared with other arguments? -- To view, visit http://gerrit.cloudera.org:8080/14775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9 Gerrit-Change-Number: 14775 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Nov 2019 20:11:10 +0000 Gerrit-HasComments: Yes
