Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )
Change subject: [java] Fix kudu-client checkstyle warnings ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java File java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java: http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java@104 PS4, Line 104: An utility class providing callbacks for successful completion of authn token re-acqusition. Not sure what happened here, but this seems like a style mistake? http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java File java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java: http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java@37 PS4, Line 37: ExternalConsistencyMode(Common.ExternalConsistencyMode pbVersion) { Why the increased visibility? http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@94 PS4, Line 94: private final SaslClientCallbackHandler saslCallback = new SaslClientCallbackHandler(); Maybe the original intent was for this to be static too? Or is the base implementation (CallbackHandler) stateful? Anyway stateless is fine too. -- To view, visit http://gerrit.cloudera.org:8080/14775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9 Gerrit-Change-Number: 14775 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Nov 2019 19:53:51 +0000 Gerrit-HasComments: Yes
