Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 )
Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14601/3/src/kudu/master/table_metrics.cc File src/kudu/master/table_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14601/3/src/kudu/master/table_metrics.cc@36 PS3, Line 36: METRIC_DEFINE_gauge_string(table, live_row_count, "Table Live Row count", I understand the desire to show "N/A" when a table doesn't support live row counting, but how are metric consumers supposed to use this if its value is a string? I don't think all consumers can cope with that. And to those that would convert a numeric string into a pure numeric value, how would they treat "N/A"? -- To view, visit http://gerrit.cloudera.org:8080/14601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533 Gerrit-Change-Number: 14601 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2019 07:14:41 +0000 Gerrit-HasComments: Yes
