Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: Import Impala's blocked based BloomFilter ...................................................................... Patch Set 5: (7 comments) Just nits http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG Commit Message: PS5: A few nits on writing commit messages as per guidelines mentioned at https://kudu.apache.org/docs/contributing.html#_submitting_patches Please take a look at https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines As for formatting, please keep the lines in the description under 72 chars long, if possible. http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG@7 PS5, Line 7: blocked based block-based ? http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG@9 PS5, Line 9: blocked based block-based ? http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG@10 PS5, Line 10: predicate predicates ? http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG@12 PS5, Line 12: part a part http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG@13 PS5, Line 13: kudu Kudu http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG@15 PS5, Line 15: generated auto-generated -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2019 04:47:17 +0000 Gerrit-HasComments: Yes
