Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: [util] Import Impala's block based BloomFilter ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14745/5//COMMIT_MSG@22 PS5, Line 22: from earlier version in Impala. : : AVX2 operations are used which leads to following scenarios: : 1) Compiler lacks AVX2 support. : Code is conditionally compiled using USE_AVX2 macro. : 2) Compil > Done. Production builds all use gcc, so I guess we'll never be in state #1. Except for the odd ducks using parts of Kudu in ARM and what not; they're also the ones who conditionalized the AVX2 support in the thirdparty build. http://gerrit.cloudera.org:8080/#/c/14745/5/src/kudu/util/block_bloom_filter-test.cc File src/kudu/util/block_bloom_filter-test.cc: http://gerrit.cloudera.org:8080/#/c/14745/5/src/kudu/util/block_bloom_filter-test.cc@88 PS5, Line 88: } > shared_ptr is needed so that Close() can be invoked on the BBFs created by Right, I see what you mean; the lack of a default constructor means you can't constructor a vector of BBFs. However, shared_ptr is still overkill; unique_ptr should be sufficient. http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter-test.cc File src/kudu/util/block_bloom_filter-test.cc: http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter-test.cc@59 PS7, Line 59: CHECK_OK(bf->Init(log_space_bytes)); Could you also test the failure condition where log_space_bytes is too large? http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter.cc@177 PS7, Line 177: this-> Do you actually need this-> here and below? -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 7 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 19:22:05 +0000 Gerrit-HasComments: Yes
