Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: [util] Import Impala's block based BloomFilter ...................................................................... Patch Set 7: (3 comments) > Patch Set 7: Verified-1 > > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/19779/ : FAILURE Unrelated test failure MaintenanceManagerTest.TestPriorityOpLaunch in TSAN. http://gerrit.cloudera.org:8080/#/c/14745/5/src/kudu/util/block_bloom_filter-test.cc File src/kudu/util/block_bloom_filter-test.cc: http://gerrit.cloudera.org:8080/#/c/14745/5/src/kudu/util/block_bloom_filter-test.cc@88 PS5, Line 88: } > Right, I see what you mean; the lack of a default constructor means you can Callers of CreateBloomFilter() need to act on the returned BFF. So if I were to use vector of unique_ptrs then the ownership would transfer to the vector and caller can't use the returned BFF directly. In that case CreateBloomFilter() could return index/handle to the created BF and add helper methods to Insert and Find using the index which is not clean/intuitive. http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter-test.cc File src/kudu/util/block_bloom_filter-test.cc: http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter-test.cc@59 PS7, Line 59: CHECK_OK(bf->Init(log_space_bytes)); > Could you also test the failure condition where log_space_bytes is too larg Done http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/14745/7/src/kudu/util/block_bloom_filter.cc@177 PS7, Line 177: this-> > Do you actually need this-> here and below? Yes, we need to specify the object explicitly, so "this" is unavoidable to invoke another member function via a function pointer. Took a while to figure this out. http://umich.edu/~eecs381/handouts/Pointers_to_memberfuncs.pdf -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 7 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 22:14:02 +0000 Gerrit-HasComments: Yes
