Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14856 )
Change subject: fs: make some fields optional ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14856/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14856/2//COMMIT_MSG@17 PS2, Line 17: yes. I wouldn't claim backward compatibility here since apparently it's not backward compatible -- components of prior versions don't expect fields to be missing (that's what optional is about, right?) http://gerrit.cloudera.org:8080/#/c/14856/2//COMMIT_MSG@16 PS2, Line 16: continues to : use It's not only use, but populate all of them. How to guarantee that? And is it necessary to guarantee that all? Also, where are these structures persisted? On the disk? -- To view, visit http://gerrit.cloudera.org:8080/14856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5378391a94e5faa54a11a277d9191d151e0225d5 Gerrit-Change-Number: 14856 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Dec 2019 02:58:00 +0000 Gerrit-HasComments: Yes
