Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14856 )
Change subject: fs: mark 'filesystem_block_size_bytes' optional ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14856/4/src/kudu/fs/fs.proto File src/kudu/fs/fs.proto: http://gerrit.cloudera.org:8080/#/c/14856/4/src/kudu/fs/fs.proto@71 PS4, Line 71: // This must be present if this instance belongs to a data directory. > FWIW, it's cheap to figure this out, and it could be useful if we ever want Yeah it's not a dealbreaker to keep this 'required', but I don't want to force that on further directory management. -- To view, visit http://gerrit.cloudera.org:8080/14856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5378391a94e5faa54a11a277d9191d151e0225d5 Gerrit-Change-Number: 14856 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Dec 2019 21:52:04 +0000 Gerrit-HasComments: Yes
