Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14856 )
Change subject: fs: make some fields optional ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14856/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14856/2//COMMIT_MSG@17 PS2, Line 17: yes. > To Andrew's point, it's important to remember the (narrow) way in which we Adar, thank you for the explanation. I'm just trying to understand what the statement on the backward compatibility means in this context. I'm OK with making this change if it's really needed if we keep an eye on the code working with these used-to-be-mandatory fields. At least, maybe add comments into the modified .proto file for the affected fields mentioning that these fields have to be populated when used in the DataDirManager. Otherwise, since we don't prohibit running older Kudu binaries with newer data (like in case of rolled-back upgrade), it's possible to hit the introducing incompatibility. -- To view, visit http://gerrit.cloudera.org:8080/14856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5378391a94e5faa54a11a277d9191d151e0225d5 Gerrit-Change-Number: 14856 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Dec 2019 06:31:17 +0000 Gerrit-HasComments: Yes
