Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: [util] Import Impala's block based BloomFilter ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/14745/9/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/14745/9/src/kudu/util/block_bloom_filter.cc@83 PS9, Line 83: directory_mask_ = (1ULL << std::min(63, log_num_buckets_)) - 1; > seems 'log_num_buckets_' is always less than 63 according to Line77. Done http://gerrit.cloudera.org:8080/#/c/14745/9/src/kudu/util/block_bloom_filter.cc@108 PS9, Line 108: new_bucket[i] = : (kRehash[i] * hash) >> ((1 << kLogBucketWordBits) - kLogBucketWordBits); > The code would look nicer if we didn't wrap(newline) it, what do you think? Done http://gerrit.cloudera.org:8080/#/c/14745/9/src/kudu/util/block_bloom_filter.cc@113 PS9, Line 113: __m128i new_bucket_sse = : _mm_load_si128(reinterpret_cast<__m128i*>(new_bucket + 4 * i)); > the same. Done http://gerrit.cloudera.org:8080/#/c/14745/9/src/kudu/util/block_bloom_filter.cc@124 PS9, Line 124: BucketWord hval = : (kRehash[i] * hash) >> ((1 << kLogBucketWordBits) - kLogBucketWordBits); > the same. Done -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 9 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 19:06:47 +0000 Gerrit-HasComments: Yes
