Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 )
Change subject: WIP [master] KUDU-3016 don't lump together updates on all tablet reports ...................................................................... Patch Set 1: (2 comments) Seems like a reasonable approach to me. I'd like to understand the perf impact though; could you deploy it to a cluster with a large number of replicas and gauge the impact on a beefy TSHeartbeat? http://gerrit.cloudera.org:8080/#/c/14897/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14897/1/src/kudu/master/catalog_manager.cc@4282 PS1, Line 4282: std::move(actions), FLAGS_consensus_max_batch_size_bytes); This seems rather low (1 MB). How does the consensus queue behave if this is value exceeds --consensus_max_batch_size_bytes? Seems like it'll read just one message from the log cache as that message reflects this Write, right? Is the concern with using --rpc_max_message_size that there's enough bookkeeping overhead that we could very well exceed the maximum transfer size even if the underlying chunking respects it? http://gerrit.cloudera.org:8080/#/c/14897/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14897/1/src/kudu/master/sys_catalog.cc@508 PS1, Line 508: generator(*this, max_chunk_size, std::move(input), &left, req); The multi-level lambda stuff makes this tricky to read. Could you make chunked_writer a private SysCatalogTable function instead of a lambda? -- To view, visit http://gerrit.cloudera.org:8080/14897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e8ca4bc8db7cab8fee6b4a40f48adc8752e7c5 Gerrit-Change-Number: 14897 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 12 Dec 2019 18:05:25 +0000 Gerrit-HasComments: Yes
