Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 )
Change subject: WIP [master] KUDU-3016 don't lump together updates on all tablet reports ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14897/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14897/1/src/kudu/master/catalog_manager.cc@4282 PS1, Line 4282: std::move(actions), FLAGS_consensus_max_batch_size_bytes); > Yeah I don't know why consensus_max_batch_size_bytes exists, or why it is a Asked Todd for more context on this, and that's the summary: * The --rpc_max_message_size helps at different level when some bit is flipped or payload for RPC has become big for some other reason * Sending too big Raft batches doesn't make much sense when memory pressure hits -- to much of wasted network bandwidth in that case * Larger size of Raft batches consume more buffer/memory to prepare and process transactions on both server and client sides * In general, a RPC might include some other extra cruft, so a separate control over the size of Raft transactions is needed anyways -- To view, visit http://gerrit.cloudera.org:8080/14897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e8ca4bc8db7cab8fee6b4a40f48adc8752e7c5 Gerrit-Change-Number: 14897 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 16 Dec 2019 19:10:08 +0000 Gerrit-HasComments: Yes
