Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 )
Change subject: [master] KUDU-3016 don't lump together updates on all tablet reports ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14897/4/src/kudu/common/row_operations.h File src/kudu/common/row_operations.h: http://gerrit.cloudera.org:8080/#/c/14897/4/src/kudu/common/row_operations.h@56 PS4, Line 56: Estimate An alternative would be having sort of Pop() method that removes the last actually added row. Probably, if targeting for success most of the times (i.e. not going over a limit on the size of the result protobuf), the alternative approach is better if thinking about the performance. From the other side, adding a big row might involve costly memory re-allocations and memcpy() which will be wasted if removing the last added element. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/14897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e8ca4bc8db7cab8fee6b4a40f48adc8752e7c5 Gerrit-Change-Number: 14897 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 09 Jan 2020 21:04:40 +0000 Gerrit-HasComments: Yes
