Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14903 )
Change subject: [metrics] Support SUM, MAX and MIN merge types for AtomicGauge ...................................................................... Patch Set 3: (4 comments) > Patch Set 2: > > +1 to all Adar's comments. I'm also curious which metrics you intend on > updating the merge policies for. A metric like 'last_consult_time' of a tablet. http://gerrit.cloudera.org:8080/#/c/14903/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14903/2//COMMIT_MSG@10 PS2, Line 10: metric > metrics Done http://gerrit.cloudera.org:8080/#/c/14903/2/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/14903/2/src/kudu/util/metrics-test.cc@270 PS2, Line 270: ASSERT_EQ(1, start_time_for_merge->value()); > Could you add to this a decrement of mem_usage to a value below 2 and show Done http://gerrit.cloudera.org:8080/#/c/14903/2/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14903/2/src/kudu/util/metrics.h@434 PS2, Line 434: // Type of behavior when two metrics merge together, it only take effect on the result > Add a comment explaining what this enum means and a high-level description Done http://gerrit.cloudera.org:8080/#/c/14903/2/src/kudu/util/metrics.h@1130 PS2, Line 1130: NeededInMerge(other)) { > This is repeated across all three cases; do it once and store in a local va Done -- To view, visit http://gerrit.cloudera.org:8080/14903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1acad40c2b73cfeb16e0dc4ad5ffba4f19167c81 Gerrit-Change-Number: 14903 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2019 06:33:00 +0000 Gerrit-HasComments: Yes
