Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14903 )
Change subject: [metrics] Support SUM, MAX and MIN merge types for metrics ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14903/4/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14903/4/src/kudu/util/metrics.h@1147 PS4, Line 1147: LOG(FATAL) << "Unknown AtomicGauge type: " << prototype()->name(); > nit: maybe also include the 'type_' value, in case this ever triggers and w ‘type_’ is an enum class value, which is not convenient to logging, and this line is unreachable. http://gerrit.cloudera.org:8080/#/c/14903/3/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14903/3/src/kudu/util/metrics.h@436 PS3, Line 436: enum class MergeType { > I don't think this note is necessary; it's obvious from inspection that onl Done http://gerrit.cloudera.org:8080/#/c/14903/3/src/kudu/util/metrics.h@442 PS3, Line 442: > minimum Done -- To view, visit http://gerrit.cloudera.org:8080/14903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1acad40c2b73cfeb16e0dc4ad5ffba4f19167c81 Gerrit-Change-Number: 14903 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2019 02:23:48 +0000 Gerrit-HasComments: Yes
