Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14903 )
Change subject: [metrics] Support SUM, MAX and MIN merge types for AtomicGauge ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14903/3/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14903/3/src/kudu/util/metrics.h@436 PS3, Line 436: // NOTE: Now only AtomicGauge support it. I don't think this note is necessary; it's obvious from inspection that only AtomicGauge uses the MergeType argument, and this comment will become stale and will need to be updated if that changes. http://gerrit.cloudera.org:8080/#/c/14903/3/src/kudu/util/metrics.h@442 PS3, Line 442: miniimum minimum -- To view, visit http://gerrit.cloudera.org:8080/14903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1acad40c2b73cfeb16e0dc4ad5ffba4f19167c81 Gerrit-Change-Number: 14903 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2019 21:15:53 +0000 Gerrit-HasComments: Yes
