Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy File src/kudu/.clang-tidy: http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy@54 PS2, Line 54: -readability-braces-around-statements It was in the original version, but isn't it useful? Given the information at https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-init.html I think it is. -- To view, visit http://gerrit.cloudera.org:8080/14930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95 Gerrit-Change-Number: 14930 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Dec 2019 21:13:24 +0000 Gerrit-HasComments: Yes
