Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py File build-support/clang_tidy_gerrit.py: http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py@58 PS3, Line 58: # Note: this will incorporate any configuration from .clang-tidy. > I don't think that's true. I played around with adding/removing that new op If I revert this change, then tidy bot doesn't complain about readibility-magic-numbers check on FastHash change locally https://gerrit.cloudera.org/c/14934/ . Let me try to figure what's going wrong... -- To view, visit http://gerrit.cloudera.org:8080/14930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95 Gerrit-Change-Number: 14930 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Dec 2019 18:16:24 +0000 Gerrit-HasComments: Yes
