Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py File build-support/clang_tidy_gerrit.py: http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py@58 PS3, Line 58: # Note: this will incorporate any configuration from .clang-tidy. > I think the config file .clang-tidy needs to be in the base kudu directory I don't think that's true. I played around with adding/removing that new option that justified this commit, and I saw clang-tidy warn/not-warn appropriately. Also, the clang-tidy docs say that every parent directory from the source file all the way back to root is searched for .clang-tidy: Configuration files: clang-tidy attempts to read configuration for each source file from a .clang-tidy file located in the closest parent directory of the source file. If any configuration options have a corresponding command-line option, command-line option takes precedence https://clang.llvm.org/extra/clang-tidy/ -- To view, visit http://gerrit.cloudera.org:8080/14930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95 Gerrit-Change-Number: 14930 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Dec 2019 01:33:51 +0000 Gerrit-HasComments: Yes
