Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14934 )
Change subject: [util] Import FastHash hash function to util ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h File src/kudu/util/hash_util.h: http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h@71 PS3, Line 71: // Compute 64-bit FastHash. Nit: add an empty line before to separate the FastHash commentary from the two implementations. http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h@73 PS3, Line 73: static inline uint64_t FastHash64(const void* buf, size_t len, uint64_t seed) { Is the inline keyword needed here and below? The function is defined entirely in the header; won't it be inlined automatically by the compiler? -- To view, visit http://gerrit.cloudera.org:8080/14934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0a21d6af10d9ba0dbd9ab46d73552d42976e8d7 Gerrit-Change-Number: 14934 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2019 22:40:01 +0000 Gerrit-HasComments: Yes
