Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14934 )
Change subject: [util] Import FastHash hash function to util ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h File src/kudu/util/hash_util.h: http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h@71 PS3, Line 71: // Implementation is adapted from https://code.google.com/archive/p/fast-hash/ > Nit: add an empty line before to separate the FastHash commentary from the Done http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h@73 PS3, Line 73: ATTRIBUTE_NO_SANITIZE_INTEGER > Is the inline keyword needed here and below? The function is defined entire Compiler should inline this function since it's in the header but explicitly mentioning it hints the compiler and also hints the reader why the function is defined in the header and shouldn't be moved to .cc file. -- To view, visit http://gerrit.cloudera.org:8080/14934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0a21d6af10d9ba0dbd9ab46d73552d42976e8d7 Gerrit-Change-Number: 14934 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2019 00:15:02 +0000 Gerrit-HasComments: Yes
