Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14934 )
Change subject: [util] Import FastHash hash function to util ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h File src/kudu/util/hash_util.h: http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h@71 PS3, Line 71: // Implementation is adapted from https://code.google.com/archive/p/fast-hash/ > Done Not quite what I meant. Here's how I think it should look: // FastHash is ... // Implementation is ... // // Compute 64-bit FastHash. // static inline uint64_t FastHash64(...) { ... } // // Compute 32-bit FastHash. // static inline uint32_t FastHash32(...) { ... } Meaning, the generic FastHash commentary should be separated from the two "function comment + function" blocks, to emphasize that the commentary applies to both blocks. http://gerrit.cloudera.org:8080/#/c/14934/3/src/kudu/util/hash_util.h@73 PS3, Line 73: ATTRIBUTE_NO_SANITIZE_INTEGER > That's +1 to Adar's comment. See https://llvm.org/docs/CodingStandards.htm I don't feel strongly about this. -- To view, visit http://gerrit.cloudera.org:8080/14934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0a21d6af10d9ba0dbd9ab46d73552d42976e8d7 Gerrit-Change-Number: 14934 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sun, 29 Dec 2019 18:48:14 +0000 Gerrit-HasComments: Yes
