Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14943 )
Change subject: [consensus] respond lock-free to RequestVote() if busy ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14943/3/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/14943/3/src/kudu/consensus/raft_consensus.h@579 PS3, Line 579: DON_NOT_SET I suppose you meant DO_NOT_SET http://gerrit.cloudera.org:8080/#/c/14943/3/src/kudu/consensus/raft_consensus.h@586 PS3, Line 586: presrcibed typo: prescribed http://gerrit.cloudera.org:8080/#/c/14943/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14943/3/src/kudu/consensus/raft_consensus.cc@2236 PS3, Line 2236: Substitute("$0Leader $1election vote request", : LogPrefixThreadSafe(), : request.is_pre_election() ? "pre-" : ""); Nit:Same code as Unlocked variant. So perhaps this logic could be a separate function. -- To view, visit http://gerrit.cloudera.org:8080/14943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95d5cbe455fefc4cdc540ee1e7b69e1f21b6ebc0 Gerrit-Change-Number: 14943 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 26 Dec 2019 22:38:05 +0000 Gerrit-HasComments: Yes
