Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14943 )
Change subject: [consensus] respond lock-free to RequestVote() if busy ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14943/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14943/2/src/kudu/consensus/raft_consensus.cc@2342 PS2, Line 2342: FillVoteResponseVoteDenied(ConsensusErrorPB::CONSENSUS_BUSY, response, : ResponderTermPolicy::CLEAR); > Yeah I was asking whether it's safe for us to change this field so that it' As far as I can see, the only benefit of sending the responder's term along with NO vote is about cases described here: https://github.com/apache/kudu/blob/8a36055bc0f96258e006475f33ecff29ab7caee0/src/kudu/consensus/raft_consensus.cc#L2590-L2602 That's a case when there isn't a stable leadership from the point of view of a majority of replicas. The optimization of short-circuited NO vote response is for the case when there is a stable leadership from the responders' point of view. -- To view, visit http://gerrit.cloudera.org:8080/14943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95d5cbe455fefc4cdc540ee1e7b69e1f21b6ebc0 Gerrit-Change-Number: 14943 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 30 Dec 2019 03:29:25 +0000 Gerrit-HasComments: Yes
