Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14943 )
Change subject: [consensus] respond lock-free to RequestVote() if busy ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14943/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14943/2/src/kudu/consensus/raft_consensus.cc@2342 PS2, Line 2342: "replica is already servicing an update from " : "a current leader or another vote > If leaving it as-is (i.e. not even clearing) is simpler to grasp, I can pos Yeah I was asking whether it's safe for us to change this field so that it's no longer set in these responses. From a protobuf standpoint it's fine (as it's optional), but I couldn't really tell whether the rest of the consensus code assumes it is always set. If you say it's not used by the receiver in these cases, I can buy it. -- To view, visit http://gerrit.cloudera.org:8080/14943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95d5cbe455fefc4cdc540ee1e7b69e1f21b6ebc0 Gerrit-Change-Number: 14943 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 29 Dec 2019 18:10:16 +0000 Gerrit-HasComments: Yes
