Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14977 )
Change subject: KUDU-3011 p2: mechanism to quiesce leadership ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14977/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14977/2/src/kudu/consensus/raft_consensus.cc@444 PS2, Line 444: if (server_ctx_.quiescing && server_ctx_.quiescing->load()) { > Will it be possible to quiesce a tserver as it is bootstrapping replicas? I You're right for the singe replica case, but it seems like failure to start an election is usually inconsequential via warning logs. I'll follow suit in the single replica case. http://gerrit.cloudera.org:8080/#/c/14977/2/src/kudu/tserver/tablet_server.h File src/kudu/tserver/tablet_server.h: http://gerrit.cloudera.org:8080/#/c/14977/2/src/kudu/tserver/tablet_server.h@107 PS2, Line 107: // The options passed at construction time. : const TabletServerOptions opts_; : > Make it an std::atomic and forgo the lock? Done -- To view, visit http://gerrit.cloudera.org:8080/14977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eb3778fe094647bc5f61f97971087d7efb8af5e Gerrit-Change-Number: 14977 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 07:50:41 +0000 Gerrit-HasComments: Yes
