Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14977 )
Change subject: KUDU-3011 p2: mechanism to quiesce leadership ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14977/4/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14977/4/src/kudu/consensus/raft_consensus.cc@382 PS4, Line 382: WARN_NOT_OK(StartElection(NORMAL_ELECTION, INITIAL_SINGLE_NODE_ELECTION), : "Couldn't start leader election"); > I was worried about IO-related failures e.g. updating cmeta or writing a WA Failing to write cmeta or failing to write a WAL entry would lead to a crash, since failures of WALs and metadata aren't tolerated right now. One such pathway is in StartElection() we call SetVotedForCurrentTermUnlocked(), which does IO to write the cmeta -- that's wrapped in a CHECK (as are many WAL and metadata operations, probably from a time before it was considered better practice to LOG(FATAL) instead). -- To view, visit http://gerrit.cloudera.org:8080/14977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eb3778fe094647bc5f61f97971087d7efb8af5e Gerrit-Change-Number: 14977 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 21:59:35 +0000 Gerrit-HasComments: Yes
