Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14977 )
Change subject: KUDU-3011 p2: mechanism to quiesce leadership ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14977/4/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14977/4/src/kudu/consensus/raft_consensus.cc@382 PS4, Line 382: WARN_NOT_OK(StartElection(NORMAL_ELECTION, INITIAL_SINGLE_NODE_ELECTION), : "Couldn't start leader election"); > So for singleton replicas, when should we expect this to fail? What's the o If the replica is being shut down, StartElection() can fail. There also seem to be some invariant-related error statuses that can surface here. The main "expected" error is that for quiescing, which is tested in TServerQuiescingParamITest.TestNoElectionsForNewReplicas: it'll be a follower until we stop quiescing the server and we can start an election. I.e. when we stop quiescing the server, the failure detector will pop and we'll see elections happen. -- To view, visit http://gerrit.cloudera.org:8080/14977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eb3778fe094647bc5f61f97971087d7efb8af5e Gerrit-Change-Number: 14977 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 21:26:46 +0000 Gerrit-HasComments: Yes
