Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14979 )
Change subject: tablet: detach metrics first in destructor ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14979/1/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/14979/1/src/kudu/tablet/tablet.h@774 PS1, Line 774: FunctionGaugeDetacher metric_detacher_; Maybe, it's a good time to make a revision of all occurrences of FunctionGaugeDetacher elsewhere in the code as well, moving those members to the very end of the list? Or that would be too much for the scope of this patch? -- To view, visit http://gerrit.cloudera.org:8080/14979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib32120178a68b5389e167643e9bb8b89f8c625b9 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 03:52:21 +0000 Gerrit-HasComments: Yes
