Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14979 )
Change subject: tablet: detach metrics first in destructor ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14979/2/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/14979/2/src/kudu/consensus/raft_consensus.h@938 PS2, Line 938: FunctionGaugeDetacher metric_detacher_; Thank you for making these changes! Do you mind adding a small comment for the changed lines, so it would be easier to keep the order of the things in the future? https://github.com/apache/kudu/blob/4f22c0f9a6e8d41ec5efa0bba25aed55936a9f91/src/kudu/clock/hybrid_clock.h#L206-L208 I looked at how to automatically enforce that, but it seems offsetof() macro sometimes wouldn't work because of some non-standard classes layout. Automating this stuff requires some extra macroing, and I'm not sure it's worth it. Probably, a comment would be the best choice. -- To view, visit http://gerrit.cloudera.org:8080/14979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib32120178a68b5389e167643e9bb8b89f8c625b9 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 05:13:50 +0000 Gerrit-HasComments: Yes
