Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14979 )
Change subject: tablet: detach metrics first in destructor ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14979/2/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/14979/2/src/kudu/consensus/raft_consensus.h@938 PS2, Line 938: // NOTE: it's important that this is the first member to be destructed. This > Done Thanks! It could be a compile-time assert for something like sizeof(outer_class) == offsetof(outer_class, metric_detacher) + sizeof(metric_detacher) However, offsetof() has its quirks. -- To view, visit http://gerrit.cloudera.org:8080/14979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib32120178a68b5389e167643e9bb8b89f8c625b9 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 07:54:02 +0000 Gerrit-HasComments: Yes
