[email protected] has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14964 )

Change subject: KUDU-3007. Support building Kudu on aarch64 platform
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14964/7/src/kudu/gutil/cpu.cc
File src/kudu/gutil/cpu.cc:

http://gerrit.cloudera.org:8080/#/c/14964/7/src/kudu/gutil/cpu.cc@271
PS7, Line 271:   has_broken_neon_ = false;
> Isn't this the default value?
1. We can't get cpu brand like x86 or from 'proc/cpuinfo' for aarch64 
server/instance, and we have no idea how to get it, do you have any good 
suggestion?
2. Aarch64 supports neon, the we set the flag to false always.



--
To view, visit http://gerrit.cloudera.org:8080/14964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97
Gerrit-Change-Number: 14964
Gerrit-PatchSet: 7
Gerrit-Owner: liusheng <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: liusheng <[email protected]>
Gerrit-Comment-Date: Tue, 07 Jan 2020 07:15:06 +0000
Gerrit-HasComments: Yes

Reply via email to