[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 )
Change subject: KUDU-3007. Support building Kudu on aarch64 platform ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/14964/7/src/kudu/gutil/cpu.cc File src/kudu/gutil/cpu.cc: http://gerrit.cloudera.org:8080/#/c/14964/7/src/kudu/gutil/cpu.cc@271 PS7, Line 271: has_broken_neon_ = false; > Maybe, the approach used for aarm64 in https://github.com/google/cpu_featur Thanks for replying. According https://github.com/google/cpu_features/blob/99d2363c6278af63f26ed93e0c922dad348ba88a/src/utils/list_cpu_features.c https://github.com/google/cpu_features/blob/3d71a964f587bbcef2aebcfb8d2a2cb7b5182bf6/src/cpuinfo_aarch64.c we can find there is no brand info for aarch64. http://gerrit.cloudera.org:8080/#/c/14964/7/src/kudu/util/debug-util.h File src/kudu/util/debug-util.h: http://gerrit.cloudera.org:8080/#/c/14964/7/src/kudu/util/debug-util.h@34 PS7, Line 34: #define FUTEX_WAIT 0 : #define FUTEX_WAKE 1 : #define FUTEX_PRIVATE_FLAG 128 > Where are these used and are they architecture-specific? Could you add a c They are used in https://github.com/apache/kudu/blob/148a0c7bec6554724339a2235cbd723fb74be339/src/kudu/util/debug-util.cc we update file src/kudu/gutil/linux_syscall_support.h where they were defined in. -- To view, visit http://gerrit.cloudera.org:8080/14964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 7 Gerrit-Owner: liusheng <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: liusheng <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 01:41:06 +0000 Gerrit-HasComments: Yes
