Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 )
Change subject: KUDU-3007. Support building Kudu on aarch64 platform ...................................................................... Patch Set 7: > I thought to make the building process sucessfully to be the first step, ane > then fix and make the unit tests passed. sorry, my fault, I wll try to run > unitests on aarch64 and share the results here. Here's what I would suggest: 1. Work on one large patch that, when applied, you can successfully build Kudu and run all unit tests from end-to-end. 2. After that's done, take a step back, look at the patch, and decide how it should be carved up for review. 3. Publish N code reviews (where N >= 1) that, taken together, add aarch64 support to Kudu. Maybe N is 1 because one giant patch is good enough. Maybe it's > 1 because there are different logical areas of division. That's your call. Either way, we will have confidence that the changes that were made are correct, and the focus of the review will be to improve maintainability/readability rather than to prove correctness. -- To view, visit http://gerrit.cloudera.org:8080/14964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 7 Gerrit-Owner: liusheng <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: liusheng <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 21:46:58 +0000 Gerrit-HasComments: No
