Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14988 )
Change subject: file cache: unify across file types ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14988/2/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: http://gerrit.cloudera.org:8080/#/c/14988/2/src/kudu/util/file_cache.cc@682 PS2, Line 682: > Not following; if it == descs->end() (and mode isn't CREATE_IF_NOT_EXIST), Ugh, I misread this as being initialized to descs->find(). -- To view, visit http://gerrit.cloudera.org:8080/14988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e5cf6cadb7f0d45492af8b8a7541853d587409c Gerrit-Change-Number: 14988 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 08 Jan 2020 22:54:29 +0000 Gerrit-HasComments: Yes
