Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14988 )
Change subject: file cache: unify across file types ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14988/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14988/2//COMMIT_MSG@21 PS2, Line 21: the nit: remove http://gerrit.cloudera.org:8080/#/c/14988/2/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: http://gerrit.cloudera.org:8080/#/c/14988/2/src/kudu/util/file_cache.cc@682 PS2, Line 682: desc Isn't it UB if this is descs->end()? -- To view, visit http://gerrit.cloudera.org:8080/14988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e5cf6cadb7f0d45492af8b8a7541853d587409c Gerrit-Change-Number: 14988 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 08 Jan 2020 19:53:30 +0000 Gerrit-HasComments: Yes
