Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: [WIP] KUDU-2973 Normalize table names for Ranger ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15018/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15018/2//COMMIT_MSG@7 PS2, Line 7: [WIP] KUDU-2973 Normalize table names for Ranger Does this commit satisfy KUDU-2973 in full? It's not clear (in part because the description in KUDU-2973 is so sparse). http://gerrit.cloudera.org:8080/#/c/15018/2//COMMIT_MSG@12 PS2, Line 12: sensitive You mean insensitive right? http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/master/CMakeLists.txt@65 PS2, Line 65: kudu_ranger Nit: out of order. http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/ranger/CMakeLists.txt File src/kudu/ranger/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/ranger/CMakeLists.txt@25 PS2, Line 25: kudu_common) Why this dependency? I don't see any includes in the new code that pulls in code from src/kudu/common. -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Jan 2020 05:27:33 +0000 Gerrit-HasComments: Yes
