Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Normalize table names for Ranger ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu/master/catalog_manager.cc@5168 PS2, Line 5168: if (hms::HmsCatalog::IsEnabled() || > I think we can reuse `ParseHiveTableIdentifier` from `table_util`. Should I If we use case insensitive policy in Ranger, as Kudu table name is case sensitive what happens if the user has two tables, 'TableA' and 'tablea' and want to enforce different policies on both. Are you suggesting we should not allow Kudu table name to be case sensitive when Ranger is turned on? To avoid name inconsistency with HMS sync enabled, it is possible to use the non-normalized table name when retrieving Ranger policies and leave the NormalizeTableName for HMS sync untouched? -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Jan 2020 20:00:11 +0000 Gerrit-HasComments: Yes
